The --uptime option in tiup cannot display the uptime of TiFlash

translator_bot · June 22, 2024, 10:07pm

Note:
This topic has been translated from a Chinese forum by GPT and might contain errors.

Original topic: tiup 指定选项–uptime 无法显示tiflash的uptime

| username: Raymond

Cluster version: 6.1.2
tiup version: tiup-v1.11

I have a question. When using tiup --uptime to check the uptime of various components in the cluster, I noticed that the uptime for tiflash is not displayed, while it is shown for other components. Has anyone encountered this situation before?

I briefly looked at the tiup source code and found that there is no special handling for tiflash.

translator_bot · June 22, 2024, 10:07pm

| username: hey-hoho | Original post link

I checked the latest code on GitHub and found that the uptime for TiFlash has not been implemented:

github.com

pingcap/tiup/blob/6320e3c9a4baad73d52d74b3fb8134865cb3a902/pkg/cluster/spec/tiflash.go#L215-L244


      
          func (c *TiFlashComponent) Instances() []Instance {
          	ins := make([]Instance, 0, len(c.Topology.TiFlashServers))
          	for _, s := range c.Topology.TiFlashServers {
          		ins = append(ins, &TiFlashInstance{BaseInstance{
          			InstanceSpec: s,
          			Name:         c.Name(),
          			Host:         s.Host,
          			Port:         s.GetMainPort(),
          			SSHP:         s.SSHPort,
          
          			Ports: []int{
          				s.TCPPort,
          				s.HTTPPort,
          				s.FlashServicePort,
          				s.FlashProxyPort,
          				s.FlashProxyStatusPort,
          				s.StatusPort,
          			},
          			Dirs: []string{
          				s.DeployDir,

This file has been truncated. show original

Other components like TiKV have it implemented:

github.com

pingcap/tiup/blob/master/pkg/cluster/spec/tikv.go#L167-L194


      
          // TiKVComponent represents TiKV component.
          type TiKVComponent struct{ Topology *Specification }
          
          // Name implements Component interface.
          func (c *TiKVComponent) Name() string {
          	return ComponentTiKV
          }
          
          // Role implements Component interface.
          func (c *TiKVComponent) Role() string {
          	return ComponentTiKV
          }
          
          // Source implements Component interface.
          func (c *TiKVComponent) Source() string {
          	source := c.Topology.ComponentSources.TiKV
          	if source != "" {
          		return source
          	}
          	return ComponentTiKV

This file has been truncated. show original

I suspect this is the issue.

translator_bot · June 22, 2024, 10:07pm

| username: Raymond | Original post link

The expert is right, thank you, expert.

translator_bot · June 22, 2024, 10:07pm

| username: srstack | Original post link

Future versions will fix this issue~

translator_bot · June 22, 2024, 10:07pm

| username: system | Original post link

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.