Would "FIXME" will be fix?

ShawnYan · December 13, 2023, 2:22am

pingcap/tidb/blob/master/pkg/expression/builtin_cast.go#L840


      
          }
          
          func (b *builtinCastRealAsJSONSig) Clone() builtinFunc {
          	newSig := &builtinCastRealAsJSONSig{}
          	newSig.cloneFrom(&b.baseBuiltinFunc)
          	return newSig
          }
          
          func (b *builtinCastRealAsJSONSig) evalJSON(ctx sessionctx.Context, row chunk.Row) (res types.BinaryJSON, isNull bool, err error) {
          	val, isNull, err := b.args[0].EvalReal(ctx, row)
          	// FIXME: `select json_type(cast(1111.11 as json))` should return `DECIMAL`, we return `DOUBLE` now.
          	return types.CreateBinaryJSON(val), isNull, err
          }
          
          type builtinCastDecimalAsJSONSig struct {
          	baseBuiltinFunc
          }
          
          func (b *builtinCastDecimalAsJSONSig) Clone() builtinFunc {
          	newSig := &builtinCastDecimalAsJSONSig{}
          	newSig.cloneFrom(&b.baseBuiltinFunc)

// FIXME: `select json_type(cast(1111.11 as json))` should return `DECIMAL`, we return `DOUBLE` now.

is that will be fix? or just keep current situation?

dveeden · December 14, 2023, 4:19pm

This looks like a note for the next person working on the code that there is room for improvement. These READMEs aren’t tracked like GitHub issues. There might be an issue for this as well or not. Feel free to open an issue on GitHub if this behavior is causing issues for you. If you do so, please include some information on your situation and how this impacts you.

It looks like this comment was added around the time of TiDB v3.0 in 2017 according to git blame.

ShawnYan · December 14, 2023, 11:49pm

thank u so much, @dveeden
then let’s track in gh issue.